Skip to content

Conversation

@davidgamero
Copy link
Contributor

@davidgamero davidgamero commented Nov 19, 2025

respect http header case-insensitivity
kubernetes-client/javascript#2690

to maximize backward compatibility, this PR preserves header casing.

when a new header is set that is case-insensitively equal to an existing header, the old header key and value will be deleted prior to setting the new one.

setHeaderParam('key','value') should delete a value previously set by setHeaderParam('kEy','old-value')

Just as in HTTP/1.x, header field names are strings of ASCII
characters that are compared in a case-insensitive fashion. However,
header field names MUST be converted to lowercase prior to their
encoding in HTTP/2.

https://www.rfc-editor.org/rfc/rfc7540#section-8.1.2

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

@davidgamero davidgamero changed the title WIP Kreplace headers with same caseinsensitive key to match http spec WIP replace headers with same caseinsensitive key to match http spec Nov 19, 2025
@davidgamero davidgamero changed the title WIP replace headers with same caseinsensitive key to match http spec WIP replace headers with same case-insensitive key to match http spec Nov 19, 2025
@davidgamero davidgamero marked this pull request as ready for review November 20, 2025 22:51
@davidgamero davidgamero changed the title WIP replace headers with same case-insensitive key to match http spec [typescript] replace headers with same case-insensitive key to match http spec Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant